Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: sort by date #4390

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

chore: sort by date #4390

wants to merge 2 commits into from

Conversation

Udit-takkar
Copy link

@Udit-takkar Udit-takkar commented Jul 6, 2024 •
edited by coderabbitai bot
Loading

Fixes: #4289

Summary by CodeRabbit

  • Enhancements
    • Updated the QfRoundSelector component to sort QF rounds by isActive and beginDate.
    • Improved the rendering logic for recurring donations based on the selected QF round.

@vercel Vercel
Copy link

vercel bot commented Jul 6, 2024

@Udit-takkar is attempting to deploy a commit to the Giveth Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 6, 2024 •
edited
Loading

Walkthrough

The QfRoundSelector component in the project has been updated to sort the qfRounds by isActive and then by beginDate. This ensures that the rounds are displayed from the most recent to the least recent. The rendering logic for recurring donations based on the selected QF has also been adjusted.

Changes

File Change Summary
src/components/views/project/projectDonations/QfRoundSelector.tsx Sorted qfRounds by isActive and beginDate. Modified rendering logic for recurring donations.

Assessment against linked issues

Objective Addressed Explanation
Sort QF rounds from left to right according to most recent (#4289) ✅
Display QF rounds on the donations tab for a project sorted by date (#4289) ✅

Poem

In the land of code where changes bloom,
The QfRoundSelector swept away the gloom.
Sorted rounds by date, closest to the right,
Now the most recent shines bright and tight.
Recurring donations align with ease,
In this new logic, everyone’s pleased. 🌟

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 9e883fd and b3548ff.

Files selected for processing (1)
  • src/components/views/project/projectDonations/QfRoundSelector.tsx (2 hunks)
Files skipped from review as they are similar to previous changes (1)
  • src/components/views/project/projectDonations/QfRoundSelector.tsx

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Udit-takkar
Udit-takkar commented Jul 6, 2024
View reviewed changes
src/components/views/project/projectDonations/QfRoundSelector.tsx
Comment on lines +117 to +118
{formatMessage({
id: 'label.recurring_donation',
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i18n was missing here

coderabbitai[bot]
coderabbitai bot reviewed Jul 6, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

src/components/views/project/projectDonations/QfRoundSelector.tsx Outdated Show resolved Hide resolved
Udit-takkar
Udit-takkar commented Jul 6, 2024
View reviewed changes
src/components/views/project/projectDonations/QfRoundSelector.tsx Outdated
Comment on lines 40 to 51
projectData?.qfRounds?.sort((a, b) => {
// First, compare by isActive
const isActiveComparison = Number(b.isActive) - Number(a.isActive);

// If isActive values are the same, compare by name
if (isActiveComparison === 0) {
return a.name.localeCompare(b.name);
}

// Otherwise, return the comparison result of isActive
return isActiveComparison;
}) || [];
Copy link
Author

@Udit-takkar Udit-takkar Jul 6, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this would first sort rounds based on isActive prop and then if both have same isActive value it would display the most recent one first

@Udit-takkar Udit-takkar changed the title chore: sort alphabetically chore: sort by date Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
All-Devs
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

QF rounds should be sorted by date, where the one closest to the right is the most recent
1 participant
@Udit-takkar